Skip to content

Commit

Permalink
🔒️ Fix a wrong permission role
Browse files Browse the repository at this point in the history
A wrong role assigned to PluginManager LIST permission as
introduced in 1.8.0 causes a privilege escalation,
allowing read-only and user group the same rights as
the MANAGE permission:

- enabling/disabling plugins
- uninstalling plugins
- listing installed plugins incl. their details
- retrieving plugin notices
- deleting orphaned plugin settings
  • Loading branch information
foosel committed Aug 24, 2022
1 parent 2cbeb27 commit ef95ef1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/octoprint/plugins/pluginmanager/__init__.py
Expand Up @@ -228,7 +228,7 @@ def get_additional_permissions(self):
"name": "List plugins",
"description": gettext("Allows to list installed plugins."),
"default_groups": [READONLY_GROUP, USER_GROUP, ADMIN_GROUP],
"roles": ["manage"],
"roles": ["list"],
},
{
"key": "MANAGE",
Expand Down

0 comments on commit ef95ef1

Please sign in to comment.