💚 Add setting to disable rate limiter

Not exposed on the UI and never will be, but allows us to disable rate limiting on the API for easier E2E testing.
OctoPrint · Sep 1, 2022 · b83b574 · b83b574
1 parent 3cca3a4
commit b83b574
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.github/fixtures/with_acl/config.yaml b/.github/fixtures/with_acl/config.yaml
@@ -1,5 +1,7 @@
 accessControl:
   salt: zXmvzI3uWuTLkSPOEfA2ZLwn3f3sGUNS
+devel:
+  enableRateLimiter: false
 plugins:
   virtual_printer:
     enabled: true

diff --git a/src/octoprint/server/__init__.py b/src/octoprint/server/__init__.py
@@ -1452,7 +1452,11 @@ def after_request(response):
 
         app.config["RATELIMIT_STRATEGY"] = "fixed-window-elastic-expiry"
 
-        limiter = Limiter(app, key_func=get_remote_address)
+        limiter = Limiter(
+            app,
+            key_func=get_remote_address,
+            enabled=s.getBoolean(["devel", "enableRateLimiter"]),
+        )
 
     def _setup_i18n(self, app):
         global babel

diff --git a/src/octoprint/settings.py b/src/octoprint/settings.py
@@ -471,6 +471,7 @@ def settings(init=False, basedir=None, configfile=None, overlays=None):
         "showLoadingAnimation": True,
         "sockJsConnectTimeout": 30,
         "pluginTimings": False,
+        "enableRateLimiter": True,
     },
 }
 """The default settings of the core application."""