Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correction of obsidian tags #552

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

envico801
Copy link

@envico801 envico801 commented Mar 18, 2024

Closes #551

Possible fix to the regex of OBS_TAG_REGEXP

With the new changes, it now detects chinese characters correctly.

@envico801 envico801 changed the title Correction of obsidian tags fix: correction of obsidian tags Mar 19, 2024
@envico801
Copy link
Author

envico801 commented Mar 19, 2024

An improved version of the regex could be this one:

const OBS_TAG_REGEXP = /#([\p{L}\p{N}\p{Emoji}\p{M}_/-]+)/gu;

Allowing to recognise characters from multiple languages and some others from the unicode family.

Detailed comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the tag generation feature can only read english parts?
1 participant