Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/519 extra line break added to file link #530

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mattcoleanderson
Copy link

closes #519

@ShootingKing-AM I've tested the change manually, however I ran into issues running the python test scripts. So I wouldn't be surprised if the e2e test fails initially.

@mattcoleanderson
Copy link
Author

Before

image

After:

image

@ShootingKing-AM
Copy link
Member

Thanks for the PR. Can this be made as an setting, which is default Off. Since many people would be used to the line break by now.

@ShootingKing-AM ShootingKing-AM mentioned this pull request Feb 13, 2024
@mattcoleanderson
Copy link
Author

Thanks for the PR. Can this be made as an setting, which is default Off. Since many people would be used to the line break by now.

I can work on that.

@mattcoleanderson
Copy link
Author

mattcoleanderson commented Feb 14, 2024

Thanks for the PR. Can this be made as an setting, which is default Off. Since many people would be used to the line break by now.

@ShootingKing-AM I've added a toggle to the settings for prepending the line break.

I've also added some code to main.js that when loading settings, will merge the default settings with settings saved to data.json. I noticed that prior behavior lead to newly added default settings not being added to the settings menu unless deleted your data.json. Now that's fixed.

@mattcoleanderson
Copy link
Author

@ShootingKing-AM Any chance of merging this PR?

@ShootingKing-AM
Copy link
Member

@mattcoleanderson this is blocked by #447 :(

@samawelch
Copy link

Thanks for fixing this, @mattcoleanderson. If it's not too much to ask, could you tell me how I'd overwrite the current plugin files (installed inside Obsidian) with the changes you've made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra line break added to File Link
3 participants