Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvector/neta: fix memory leaks #3618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Apr 17, 2024

Fix some memory leaks in lib/vector/neta exposed by static analysis.

@nilason nilason added this to the 8.4.0 milestone Apr 17, 2024
@nilason nilason self-assigned this Apr 17, 2024
@github-actions github-actions bot added vector Related to vector data processing C Related code is in C libraries labels Apr 17, 2024
@echoix
Copy link
Member

echoix commented Apr 17, 2024

The three failing tests seem to be failing often for Python 3.12. They timeout.
I have two ideas. If these tests use multiple cores, since multiple test runners are launched in parallel, we might be having too much work launched. In January 2024, GitHub finished upgrading the runners to offer 4 cpu cores https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/

My second idea, is the deprecation warning shown, that the forks used might cause deadlocks in the child, and we might be in that situation.

@echoix
Copy link
Member

echoix commented Apr 17, 2024

A couple weeks ago, I tried using the number of logical cores to run tests, but got more timeouts than that (or timed out more easily).

https://pytest-xdist.readthedocs.io/en/latest/distribution.html#running-tests-across-multiple-cpus

So I didn't continue with that. We are thus using 2 runners for 4 cpu.

@nilason nilason modified the milestones: 8.4.0, 8.5.0 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C libraries vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants