-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proj_normalize_for_visualization: check other left-handed orders, not… #4084
proj_normalize_for_visualization: check other left-handed orders, not… #4084
Conversation
(&dir0 == &cs::AxisDirection::EAST && | ||
&dir1 == &cs::AxisDirection::SOUTH) || | ||
(&dir0 == &cs::AxisDirection::SOUTH && | ||
&dir1 == &cs::AxisDirection::WEST) || | ||
(&dir0 == &cs::AxisDirection::WEST && | ||
&dir1 == &cs::AxisDirection::NORTH)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced that just switching the axis is enough for those 3 coordinate system. We should also presumably transform southing to northing, westing to easting, and make sure the final order is easting, northing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is also changing other problem, that westing-southing is displayed in QGIS with Antartica at the top. In that case moving up in the screen will make the coordinates decrease. Is that normal?
I do not mean that it should not be changed (well, I got used to it in South Africa). But the initial problem in QGIS was the mirroring effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case moving up in the screen will make the coordinates decrease. Is that normal?
I guess so.
I believe all those coordinate systems should have easting,northing axis order after normalize_for_visualization. The native orders are just conventions to avoid specifying negative values, or other esoteric reasons, but ultimately you want your map with increasing eastings towards the right of the screen, and increasing northings towards the top of the screen
Maybe @thareUSGS can confirm for planetary CRS how maps in a CRS like IAU_2015:19901 "Mercury (2015) / Ographic" which has northing,westing should be displayed. I presume this should be transformed as easting,northing ?
The PROJ project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last two months and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 2 months. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the PROJ project can do to help push this PR forward please let us know how we can assist. |
… only N-E
A few CRSs use left-handed orders other than N-E, like S-W in EPSG:5513