Skip to content

Commit

Permalink
feat(naldo): [#48311] template environment variables directly
Browse files Browse the repository at this point in the history
Previously, environment variables were templated into a ConfigMap which
was referenced through an `envFrom` in the deployment. Unfortunately,
Kubernetes does not restart deployments on changes to their referenced
ConfigMaps[1], so this indirection means that deployments have to be
restarted manually every time a change is made - something that is very
easy to forget in an otherwise GitOpsy workflow.

[1] kubernetes/kubernetes#22368
  • Loading branch information
caspervk committed Jun 28, 2023
1 parent f88b298 commit f39228f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 19 deletions.
16 changes: 0 additions & 16 deletions os2mo/templates/mo/naldo-configmap.yaml

This file was deleted.

7 changes: 4 additions & 3 deletions os2mo/templates/mo/naldo-deployment.yaml
Expand Up @@ -28,9 +28,10 @@ spec:
env:
- name: PUBLIC_BASE_URL
value: "https://{{ .Values.ingress.hostname }}"
envFrom:
- configMapRef:
name: naldo-config
{{- range $name, $value := .Values.os2mo.naldo.environment }}
- name: {{ $name }}
value: {{ $value | quote }}
{{- end }}
ports:
- containerPort: 3000
resources:
Expand Down

0 comments on commit f39228f

Please sign in to comment.