Skip to content

Commit

Permalink
feat(sql_export): [#48311] template environment variables directly
Browse files Browse the repository at this point in the history
Previously, environment variables were templated into a ConfigMap which
was referenced through an `envFrom` in the deployment. Unfortunately,
Kubernetes does not restart deployments on changes to their referenced
ConfigMaps[1], so this indirection means that deployments have to be
restarted manually every time a change is made - something that is very
easy to forget in an otherwise GitOpsy workflow.

[1] kubernetes/kubernetes#22368
  • Loading branch information
caspervk committed Jun 28, 2023
1 parent e819728 commit 2317af6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 19 deletions.
16 changes: 0 additions & 16 deletions os2mo/templates/integrations/sql_export/config.yaml

This file was deleted.

8 changes: 5 additions & 3 deletions os2mo/templates/integrations/sql_export/deployment.yaml
Expand Up @@ -55,9 +55,11 @@ spec:
name: {{ .Values.sql_export.historic_state_secret_name }}
key: password
{{- end }}
envFrom:
- configMapRef:
name: sql-export

{{- range $name, $value := .Values.sql_export.environment }}
- name: {{ $name }}
value: {{ $value | quote }}
{{- end }}
ports:
- containerPort: 8000
resources:
Expand Down

0 comments on commit 2317af6

Please sign in to comment.