Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication in db.cpp, use builtin formatting in spdlog when logging, remove unnecessary usages of empty C-strings #18

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

undertheironbridge
Copy link
Contributor

db.cpp had some very repetitive code related to managing the query buffers. This is now handled by a local wrapper for std::string which provides the necessary functionality.
Also, usages of "" were replaced with equivalent functionality provided by std::string member functions where applicable, mostly in context of object construction (where it was completely removed, as the default constructor does the same thing) and checking if a string is empty.

@undertheironbridge undertheironbridge changed the title Remove code duplication in db.cpp and unnecessary usages of empty C-strings Reduce code duplication in db.cpp, use builtin formatting in spdlog when logging, remove unnecessary usages of empty C-strings May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant