New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client] select the most secure User Identity Token if a server offers multiple ones #2611
base: master
Are you sure you want to change the base?
[Client] select the most secure User Identity Token if a server offers multiple ones #2611
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2611 +/- ##
==========================================
- Coverage 54.68% 54.62% -0.07%
==========================================
Files 343 343
Lines 65216 65217 +1
Branches 13354 13354
==========================================
- Hits 35664 35622 -42
- Misses 25676 25712 +36
- Partials 3876 3883 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor improvements inline, please check.
imho we should also determine the best security policy by this function instead of the server supplied values in the SelectBestendpoint helper. But that could be done in separate PR.
|
||
byte result = 0; | ||
switch (policyUri) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - I wonder which stringcomparison policy is used here...
one typo to go... |
Also added calculated Security Level to the Endpoint Selection |
Proposed changes
This fix makes the client select the most secure UserIdentity Token if a server offers more than one.
Before the client just selected the first UserIdentity Token offered by the server.
Related Issues
Types of changes
Checklist
Further comments