New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reopen secure channel without activate #2577
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2577 +/- ##
==========================================
+ Coverage 54.64% 54.81% +0.16%
==========================================
Files 343 343
Lines 65215 65225 +10
Branches 13352 13354 +2
==========================================
+ Hits 35639 35753 +114
+ Misses 25697 25609 -88
+ Partials 3879 3863 -16 ☔ View full report in Codecov by Sentry. |
{ | ||
Utils.LogTrace("ChannelId {0}: in {1} state.", ChannelId, value); | ||
Utils.LogInfo("ChannelId {0}: in {1} state.", ChannelId, value); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remain Trace
Is this 'ready to be tried out'? |
preview nugets are available for every merge to master. So for open PRs it is easiest to clone the branch and build a nuget locally (using dotnet pack). |
Hi @KircMax, unfortunately this work isn't finished and I had to suspend for a bit. I let you know when it is ready for test. |
Proposed changes
If a socket is closed, new service calls are queued and a new channel is established without reconnect / activate.
Add some logic which ensures that a
BeginConnect
operation is only started if a valid service call is queued first.The activate is prepared by the session reconnect handler which may take some time to respond. Until then, all other service fail immediately with BadNotConnected.
Wiring up the socket failure turns out to be quite complicated, so going for the safer fix to fail the packets until BeginConnect starts.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...