New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make X509CertificateStore support CRLs on Windows #2571
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2571 +/- ##
==========================================
+ Coverage 54.62% 54.69% +0.06%
==========================================
Files 342 346 +4
Lines 65082 65253 +171
Branches 13350 13403 +53
==========================================
+ Hits 35553 35688 +135
- Misses 25661 25674 +13
- Partials 3868 3891 +23 ☔ View full report in Codecov by Sentry. |
test comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to check for the unsafe code and the implications.
@romanett please resolve conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More changes than I thought, will continue the code review next week.
Also give @ThomasNehring an opportunity to share feedback.
Proposed changes
This PR extends the existing X509 CertificateStore building on top of the .NET X509Store Class to support Certificate Revocation Lists (CRLs) This is important to make the X509Store viable for use as Trust and Issuer Store.
Considerations:
Related Issues
Types of changes
Checklist
Further comments
Documentation still a ToDo