Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable .NET Standard 2.0 builds for core library #2570

Merged
merged 24 commits into from Apr 3, 2024
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Mar 29, 2024

Proposed changes

For some specific applications like analyzers it is preferable to have a .NET Standard 2.0 build of the core library.
Client/server build for NetStandard 2.0 will be maintained, but is unsupported in Nuget package and is not part of the test matrix.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@mregen mregen added this to the April Update milestone Mar 29, 2024
@mregen mregen self-assigned this Mar 29, 2024
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.53%. Comparing base (ebb55ad) to head (637a706).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2570      +/-   ##
==========================================
- Coverage   54.65%   54.53%   -0.12%     
==========================================
  Files         342      342              
  Lines       65044    65044              
  Branches    13331    13331              
==========================================
- Hits        35547    35473      -74     
- Misses      25648    25718      +70     
- Partials     3849     3853       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen modified the milestones: April Update, March Update Apr 2, 2024
@mregen mregen marked this pull request as ready for review April 2, 2024 06:08
This reverts commit 6edfcb0.
@mregen mregen merged commit ca848af into master Apr 3, 2024
207 of 209 checks passed
@mregen mregen deleted the legacybuilds branch April 3, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not remove support for .NET Standard 2.0 until really necessary
3 participants