Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.05.04 json encoder fixes v2 #2539

Open
wants to merge 122 commits into
base: master
Choose a base branch
from

Conversation

opcfoundation-org
Copy link
Contributor

Proposed changes

Fixes to the JSON encoder to support the RC + NodeId/ExpandedNodeId/QualifiedName encoding,

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ randy-armstrong
✅ mrsuciu
❌ Randy Armstrong


Randy Armstrong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 9.04872% with 392 lines in your changes are missing coverage. Please review.

Project coverage is 44.16%. Comparing base (60689c9) to head (bb031c8).
Report is 3 commits behind head on master.

Files Patch % Lines
...s/Opc.Ua.Server/Configuration/ConfigurationFile.cs 8.40% 109 Missing ⚠️
Stack/Opc.Ua.Core/Types/BuiltIn/NodeId.cs 3.84% 73 Missing and 2 partials ⚠️
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs 0.00% 72 Missing ⚠️
Stack/Opc.Ua.Core/Types/BuiltIn/ExpandedNodeId.cs 1.56% 63 Missing ⚠️
Stack/Opc.Ua.Core/Types/BuiltIn/QualifiedName.cs 0.00% 36 Missing ⚠️
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs 0.00% 23 Missing ⚠️
Stack/Opc.Ua.Core/Types/Utils/Utils.cs 41.66% 5 Missing and 2 partials ⚠️
...a.Server/Configuration/ConfigurationNodeManager.cs 90.90% 0 Missing and 2 partials ⚠️
...Ua.Core/Types/BuiltIn/SessionLessServiceMessage.cs 0.00% 2 Missing ⚠️
Stack/Opc.Ua.Core/Stack/Client/UserIdentity.cs 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2539       +/-   ##
===========================================
- Coverage   54.62%   44.16%   -10.46%     
===========================================
  Files         342      296       -46     
  Lines       65082    61172     -3910     
  Branches    13350    12643      -707     
===========================================
- Hits        35553    27019     -8534     
- Misses      25661    31139     +5478     
+ Partials     3868     3014      -854     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants