Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.05.04 json encoder fixes #2376

Draft
wants to merge 105 commits into
base: master
Choose a base branch
from
Draft

Conversation

opcfoundation-org
Copy link
Contributor

Proposed changes

The JSON decoder now checks for JSON string in addition to handling a JSON object. If a JSON string it assumes the NodeId/ExpandedNodeId/QualfiiedName is formatted as specified in Part 6.

The JSON encoder has a flag to force the serialization of Strings instead of JSON Objects.

The JSON decode now allows an incoming message to have a different namespace table that the server.

Types of changes

Enhancement (non-breaking change which adds functionality)

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: Patch coverage is 17.46032% with 156 lines in your changes are missing coverage. Please review.

Project coverage is 53.82%. Comparing base (1541723) to head (6c02c35).
Report is 1 commits behind head on master.

❗ Current head 6c02c35 differs from pull request most recent head d91973a. Consider uploading reports for the commit d91973a to get more accurate results

Files Patch % Lines
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs 12.17% 96 Missing and 5 partials ⚠️
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs 0.00% 26 Missing and 3 partials ⚠️
Stack/Opc.Ua.Core/Schema/UANodeSetHelpers.cs 53.84% 10 Missing and 2 partials ⚠️
...ack/Opc.Ua.Core/Stack/State/NodeStateCollection.cs 0.00% 11 Missing ⚠️
...pc.Ua.Server/Diagnostics/DiagnosticsNodeManager.cs 0.00% 1 Missing ⚠️
Stack/Opc.Ua.Core/Schema/UANodeSet.cs 66.66% 1 Missing ⚠️
Stack/Opc.Ua.Core/Stack/State/NodeState.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2376       +/-   ##
===========================================
+ Coverage   36.66%   53.82%   +17.16%     
===========================================
  Files         319      334       +15     
  Lines       63015    64559     +1544     
  Branches    12952    13264      +312     
===========================================
+ Hits        23102    34747    +11645     
+ Misses      37115    26058    -11057     
- Partials     2798     3754      +956     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen marked this pull request as draft November 16, 2023 15:18
@mregen mregen marked this pull request as ready for review January 17, 2024 15:05
@mregen mregen marked this pull request as draft January 17, 2024 15:05
@mregen mregen self-requested a review January 17, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants