Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client Example In Readme File #2129

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RAJEEV2510
Copy link

@RAJEEV2510 RAJEEV2510 commented Apr 21, 2023

Proposed changes

I add the simple client example in readme file for better explations

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • [x ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [X ] I have read the CONTRIBUTING doc.
  • [ X] I have signed the CLA.
  • [X ] I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ RAJEEV2510
❌ rajeev2511
You have signed the CLA already but the status is still pending? Let us recheck it.

@mregen
Copy link
Contributor

mregen commented Sep 26, 2023

@RAJEEV2510 please move your sample to a seperate doc file under /Docs

Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Copy link
Author

@RAJEEV2510 RAJEEV2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have create new sample client readme file

@RAJEEV2510
Copy link
Author

Hey @EthanChangAED Can you review my changes once again ,So anyone can easily use this

@mregen
Copy link
Contributor

mregen commented Dec 4, 2023

Hi @RAJEEV2510 , thanks for your efforts.
I had a brief look at your documentation, I really like that you build a sample, but the way you describe is not the recommended way to build a application configuration. To avoid user errors, there is a fluent API available in the config assembly. Please use that instead.

An example to use it you can find in some of the test code, e.g. server fixture

@RAJEEV2510
Copy link
Author

@mregen Yes ,you are right, so u r going to merge it or you are going to close this issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants