Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable call of methods that are part of the types or super types of the objectId on which the method is called #1698

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Enable call of methods that are part of the types or super types of the objectId on which the method is called #1698

wants to merge 3 commits into from

Conversation

mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Feb 3, 2022

Enable call of methods that are part of the types or super types of the objectId on which the method is called.
Closes #1696

mregen
mregen reviewed Feb 7, 2022
View reviewed changes
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wonder, does it need to be fixed in every NodeManager?
A sample in the client test would be nice to have.

@mregen mregen added the bug A bug was identified and should be fixed. label Feb 18, 2022
mregen
mregen requested changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on OPCF feedback, need to wait for advise

@mrsuciu mrsuciu linked an issue May 31, 2022 that may be closed by this pull request
RolePermissions on MethodState can be bypassed #1661
Closed
5 tasks
@mrsuciu mrsuciu modified the milestone: 1.4.369 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mregen mregen mregen requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mrsuciu mrsuciu

Labels
bug A bug was identified and should be fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot call method within the ObjectType of the objectId RolePermissions on MethodState can be bypassed
2 participants
@mrsuciu @mregen