Use Viewer API in Files #878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thesola10
force-pushed
the
viewerapi
branch
from
2b6a076
to
9ce9bd7
Compare
|
i might have accidentally wiped the "new document" icons, maybe indiscriminately nuking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature mentioned in, and fixes #445 by not loading Files app hooks and letting the existing Viewer handler manage files opened from the Files app as well.
This draft currently doesn't carry over the "Open in OnlyOffice" action in the three dots menu. I'm sure a lot more code could be pruned with this change.