Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to open all files read only by default #333

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

nikkilocke
Copy link

We wanted users to be able to view Only Office files by default, rather than always being in edit mode, where it is too easy to make changes by mistake.

This branch adds a setting to turn that on, so:

  • Clicking an existing file opens it read only
  • Creating a new file opens it read write (obviously)
  • The .../right click menu in Nextcloud has an additional option "Open for editing", which opens the file for editing in the same way clicking used to do.

This also reduces the load on the server, as it doesn't have to create the database data to follow every edit, when the file is read only.

Hope you will consider including this in the next release.

@LinneyS LinneyS added the enhancement New feature or request label Aug 27, 2020
@burnoutberni
Copy link

Any updates on this?

@nikkilocke
Copy link
Author

Not sure I understand the question. Just offered the code - should I now update it to match the latest master on the main branch?

@burnoutberni
Copy link

Sorry, thought I was clear, this was actually directed at the Onlyoffice team (e.g. @LinneyS ?). I was wondering whether this PR is something they are considering to merge in one of the next releases?

@JohnOrme
Copy link

JohnOrme commented Mar 8, 2021

Came here thinking about this very thing and found @nikkilocke has already done it!
Please think about reviewing and merging this one :-) @LinneyS

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2021

CLA assistant check
All committers have signed the CLA.

@nikkilocke
Copy link
Author

Have signed the agreement.
I will look into the conflicts and push a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants