Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating ODF files by default #255

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

gary-kim
Copy link

@gary-kim gary-kim commented Mar 25, 2020

Closes #224

@LinneyS Could you take a look when you have some time?

New asset files were created with the following command from the assets directory

for i in *; do
    (cd $i && libreoffice6.3 --convert-to odt new.docx)
    (cd $i && libreoffice6.3 --convert-to odp new.pptx)
    (cd $i && libreoffice6.3 --convert-to ods new.xlsx)
done

Installed Libreoffice version for the script was LibreOffice 6.3.5.2 dd0751754f11728f69b42ee2af66670068624673 in case you want to make sure it is reproducible.

I'm assuming you want this opened against the develop branch? Not really sure, there doesn't seem to be contributing documentation here?

Signed-off-by: Gary Kim gary@garykim.dev

hellonadya and others added 6 commits March 6, 2020 15:12
- move comparison table lower
- update the table in accordance with 5.5
- add features sections
- add info on IE
Closes ONLYOFFICE#224

This adds an option for administrators to set
that makes new files be created in ODF formats
rather than OOXML formats.

New asset files were created with the following command from the assets directory
```bash
for i in *; do
    (cd $i && libreoffice6.3 --convert-to odt new.docx)
    (cd $i && libreoffice6.3 --convert-to odp new.pptx)
    (cd $i && libreoffice6.3 --convert-to ods new.xlsx)
done
```

Installed Libreoffice version for the script was `LibreOffice 6.3.5.2 dd0751754f11728f69b42ee2af66670068624673`

Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim
Copy link
Author

Should I rebase on top of the force pushed changes?

@virtualdxs
Copy link

Any progress on this? I'm looking for the same functionality, as clicking "new document" and typing test.odt creates test.odt.docx rather than test.odt.

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ LinneyS
✅ hellonadya
❌ gary-kim
You have signed the CLA already but the status is still pending? Let us recheck it.

@gary-kim
Copy link
Author

Any progress on this? I'm looking for the same functionality, as clicking "new document" and typing test.odt creates test.odt.docx rather than test.odt.

It is working but it doesn't seem to be getting attention from the maintainers.

@kosssi
Copy link

kosssi commented Mar 30, 2021

This feature is awesome, @gary-kim maybe accept the CLA and rebase your branch...

@gary-kim
Copy link
Author

gary-kim commented Apr 2, 2021

I'm sorry, I'm not willing to sign a CLA. When this was first created, there was no CLA on this repo so I wrote this feature but as a general rule, I don't sign CLAs that require giving more rights to one party than another.

@Thatoo
Copy link

Thatoo commented Jul 3, 2023

I'm sorry, I'm not willing to sign a CLA. When this was first created, there was no CLA on this repo so I wrote this feature but as a general rule, I don't sign CLAs that require giving more rights to one party than another.

I totally agree with you on the CLA.
How do we do now @kosssi ? Will you respect @gary-kim 's right and allow us to have such nice feature?

@kosssi
Copy link

kosssi commented Jul 17, 2023

I didn't do anything ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants