Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hooks for setting the name of the user and the editor permission #115

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Peterede
Copy link

Allow other apps to supply the name and editing permissions

@alexanderonlyoffice
Copy link
Member

Hello @Peterede, thank you for your interest in improving ONLYOFFICE. Could you please describe the aim to be achieved by implementing this feature list. We would ask you to describe the usage scenario.

@Peterede
Copy link
Author

In the nextcloud talk app we invite a number of guests to a meeting then share a link to a document with them. We do not want the guests to appear as anonymous, we want to use the name set in the call so this is where the name hook is used. For the editing privileges we do not want guests to be able to edit, only view, so this is where the editable hook is used.

@Peterede
Copy link
Author

@alexanderonlyoffice is there anything else needed to merge this pull request into master?

@ibnpetr ibnpetr added the help wanted Extra attention is needed label Sep 14, 2019
@juliushaertl
Copy link
Contributor

As discussed at the Nextcloud conference we should aim for a unified server UI to set the guest name across different apps. @Peterede Feel free to join the discussion in nextcloud/server#17147

@Peterede
Copy link
Author

The hooks implemented in this pull request could be used by the unified server UI to set the guest name. This will then still allow other apps to implement the hooks and extend the behaviour.

@LinneyS LinneyS added the enhancement New feature or request label Oct 13, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants