Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Viewer API in the Files app #445

Closed
Thesola10 opened this issue Mar 10, 2021 · 13 comments · May be fixed by #878
Closed

Use Viewer API in the Files app #445

Thesola10 opened this issue Mar 10, 2021 · 13 comments · May be fixed by #878
Labels
bug Something isn't working

Comments

@Thesola10
Copy link

On the new Dashboard app, when selecting an Office file from the Files widget, OnlyOffice shows up in a window with a black top bar, the same being used on Nextcloud Text.

However, on Files, while NCText still uses that window, OnlyOffice attempts to overlay its editor in a weird way, which can cause graphical issues and obscures options to leave the editor or edit sharing settings, which are more obvious on NCText.

Please consider making it so the OnlyOffice editor uses the NCText-like frame on the Files app as well -- basically everywhere NCText does.

@Thesola10
Copy link
Author

Thesola10 commented Mar 10, 2021

OnlyOffice on the Dashboard (like NCText or previews) (what I'm asking for on Files)
Capture d’écran de 2021-03-10 15-37-58

OnlyOffice on Files
Capture d’écran de 2021-03-10 15-38-20

An issue from that approach, caused by simply resizing the window
Capture d’écran de 2021-03-10 15-39-15

@violoncelloCH
Copy link

I'd also really like to see Onlyoffice using Nextcloud's viewer frame, as this provides a way more obvious way for the users to close the editor.
Technically this can be done using the viewer API: https://github.com/nextcloud/viewer/
As an example the Text app uses this API here: https://github.com/nextcloud/text/blob/master/src/viewer.js

@Thesola10
Copy link
Author

@violoncelloCH not like this would take a lot of effort -- as shown above, OnlyOffice does use the viewer API on the Dashboard, it's just a matter of making that behavior universal (and dropping whatever hack they're using on Files)

@violoncelloCH
Copy link

@Thesola10 I believe that's something that the Dashboard does, not the Onlyoffice-Integration... but yes, would make sense of course to use the proper viewer api everywhere

@Thesola10
Copy link
Author

Thesola10 commented Nov 14, 2021

I just found out this integration app already has a Viewer API binding under js/viewer.js . What exactly is preventing js/editor.js from using the same mechanism?

@Thesola10
Copy link
Author

Or even better: just discontinue the Editor logic in favor of using Viewer exclusively -- declutters code, removes useless shortcuts from the OnlyOffice interface and fixes most layout issues in the Files app in one go

@Thesola10 Thesola10 changed the title Use the overlay editor frame all the time Use Viewer API in the Files app Nov 15, 2021
@SergeyKorneyev
Copy link

Hello @Thesola10 @violoncelloCH
Initially, the ONLYOFFICE editor was designed to be opened on top of the file list, but then Nextcloud developers added the viewer interface for opening documents in other sections like Dashboard. We've adapted to support that interface, so the editor can now be opened anywhere where the viewer is used. However, it's not used in Files by default, so the editor still uses the original logic there, at the moment.
Based on your feedback, we'll consider using the viewer interface in Files.

@Thesola10

An issue from that approach, caused by simply resizing the window

Is this still reproducible with the latest Document Server and connector versions?

Or even better: just discontinue the Editor logic in favor of using Viewer exclusively -- declutters code, removes useless shortcuts from the OnlyOffice interface and fixes most layout issues in the Files app in one go

Could you create a dedicated issue for that suggestion and elaborate on it?

@Thesola10
Copy link
Author

Thesola10 commented Dec 10, 2021

Thanks for the response @SergeyKorneyev

Is this still reproducible with the latest Document Server and connector versions?

This is the same issue, on the latest release of Nextcloud (23 from NixOS), Document Server (from Docker Hub) and the Onlyoffice connector (from the App Store) on Firefox 95 Flatpak:

Capture d’écran de 2021-12-10 17-26-56

elaborate on it?

By "discontinuing the Editor logic", I meant (speculatively) that using the Viewer API on Nextcloud Files would standardize the way the connector works across Nextcloud and potentially allow the current Files overlay to be retired. I don't think it requires a separate issue.

@Thesola10
Copy link
Author

I've just noticed that, on my latest screenshot, part of the regular Files app's UI also appears to be broken -- I couldn't reproduce this without the OnlyOffice view open.

@Thesola10
Copy link
Author

Any updates? It looks like the Nextcloud 25 redesign might hinder the current overlay approach, so switching to Viewer everywhere is especially relevant I think

@LinneyS LinneyS added the bug Something isn't working label Mar 21, 2023
@LinneyS
Copy link
Member

LinneyS commented Mar 21, 2023

Fixed in v7.8.0

@LinneyS LinneyS closed this as completed Mar 21, 2023
@Thesola10
Copy link
Author

Thesola10 commented Mar 21, 2023

Upgraded to 7.8.0 and it doesn't appear to use Viewer API frames on Files... does Document Server need to be updated as well?

This issue isn't about the layout bugs in Files view, it's about using Viewer API everywhere

@Thesola10
Copy link
Author

Please consider reopening, the core issue still hasn't been addressed as of 8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants