Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add for breadcrumbs #3541

Merged

Conversation

benfurber
Copy link
Member

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Adding basic e2e tests for breadcrumbs.

@benfurber benfurber requested a review from a team as a code owner May 13, 2024 16:20
Copy link

cypress bot commented May 13, 2024

Passing run #5639 ↗︎

0 81 1 0 Flakiness 0

Details:

test: add wait time for how to comments spec
Project: onearmy-community-platform Commit: 5e03b1518a
Status: Passed Duration: 04:40 💡
Started: May 21, 2024 10:35 AM Ended: May 21, 2024 10:39 AM

Review all test suite changes for PR #3541 ↗︎

@benfurber benfurber force-pushed the chore/add-breadcrumb-cypress-tests branch from cb0ee0a to 4e62a1f Compare May 15, 2024 12:58
@benfurber benfurber force-pushed the chore/add-breadcrumb-cypress-tests branch from 803b4b0 to a0ed123 Compare May 15, 2024 15:11
@benfurber
Copy link
Member Author

Funny that I've got this test issue on a seperate how-to thing. Maybe this branch is slowing down the page enough or something?

@benfurber benfurber force-pushed the chore/add-breadcrumb-cypress-tests branch from a0ed123 to 5e03b15 Compare May 21, 2024 10:21
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.17%. Comparing base (2ab7a91) to head (5e03b15).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3541      +/-   ##
==========================================
+ Coverage   68.09%   68.17%   +0.08%     
==========================================
  Files         441      441              
  Lines       13972    13973       +1     
  Branches     2507     2507              
==========================================
+ Hits         9514     9526      +12     
+ Misses       4409     4398      -11     
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benfurber benfurber merged commit d8f9c8c into ONEARMY:master May 21, 2024
20 checks passed
@cypress cypress bot mentioned this pull request May 21, 2024
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.182.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.185.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants