feat: update title of question page

[ADTmux]

PR Checklist

• - Commit messages are descriptive, it will be used in our Release Notes

PR Type

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Developer experience (improves developer workflows for contributing to the project)

Description

Clicking a question's title changes the name of the tab to reflect that question.

Git Issues

Closes #3409

---

[ADTmux]

Please let me know if a different workaround was required, or a different approach was expected! I'd be happy to work on that as well!

[benfurber]

Thanks for this @ADTmux. I think it's better to set it on QuestionPage though and I'd love to see it tested in the cypress test for questions/read.

[ADTmux]

hey @benfurber , tested on Cypress and did the requested change. Please let me know what next is required! :)

[benfurber]

@ADTmux Sorry to request another change on a tiny commit(!) but I think it should be set during the useeffect rather than the render. Let's go with just after setQuestion(foundQuestion)

The branch is also failing the linting right now. That's easiest to fix by running yarn format.

[ADTmux]

Hi @benfurber could you test it now?

[benfurber]

Awesome. Thanks @ADTmux.

So I think that updating the commit messages to our style will fix the linter plus a rebase with master and we're good to go.

[ADTmux]

@benfurber Done!

[benfurber]

Hey @ADTmux. Thanks for making that change. Looks like you've pulled in some unrelated (and wrong) changes too? The stuff incrementViewCount on src/pages/Question/QuestionPage.tsx shouldn't be included. I think then the failing unit test will pass.

[benfurber]

Just checking in @ADTmux. Have you seen my last comment? :)