chore: deal with jest console warnings #3410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed test on run #5361 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| [Settings] > [All account types > [Can update username and password] |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #3410 ↗︎
benfurber
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Disagree with this change. logger is doing what it should be here.
There was a problem hiding this comment.
Rather than mocking logger, the tests should be anticipating the call to logger happening.
https://stackoverflow.com/questions/49096093/how-do-i-test-a-jest-console-log
There was a problem hiding this comment.
Rather than mocking logger, the tests should be anticipating the call to logger happening.
https://stackoverflow.com/questions/49096093/how-do-i-test-a-jest-console-log
|
Hey @Robert-LC hope you're well, will you have a chance to have a look at this again soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Description
I dealt with most of the Jest console warnings as well as the unnecessary logging appearing.
For
loggeritself, I expected the test log entries of debug, info, warn, fatal instead of displaying them.For
Message.store.tsxI removed the logger.error calls because the test looks for Errors thrown so no need to cloud the logging, if the tests will fail in that regard.For files that called logger.info, I switched to logger.debug instead to hide the calls in the tests, but keep them around for debugging. Let me know if you think this what the right choice for those items.
There were a few tests like in
user.store.test.tsxwhere it was testing for if two users were returned form the same id and it would return a warning, but if it wouldn't cause a failure of the test.So for those type of scenarios, I decided to mock the warning to hide from the test suite, since its not failing on expect. Let me know if you want something different in that scenario.
Lastly, while trying to figure out the best approach, I noticed that in
functions/src/test/firebase/logger.tsthere was at one point a top level mock that spied on all firebase logger methodsGit Issues
Closes #3303