Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace tag components across how-to and research #3367 #3400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simontree
Copy link

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Refactoring of components using tagList as described in the issues ticket.

Git Issues

Closes #3357

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@benfurber
Copy link
Member

@simontree - Nice work, thank you. I can see the unit tests are failing. From a quick look, it could well be because of the TagList component. A guard clause at the start of the component might do the trick e.g.:

export const TagList = ({ tags }: IProps) => {
  if (!tags) return 

  const { allTagsByKey } = useCommonStores().stores.tagsStore

@benfurber benfurber added the 🤝 Awaiting author Waiting on action from the author label Mar 29, 2024
@benfurber benfurber self-assigned this Mar 29, 2024
@benfurber
Copy link
Member

Hey @simontree. How are you getting on?

@simontree
Copy link
Author

Hey @simontree. How are you getting on?

Hey @benfurber, I am working on my bachelor thesis right now - but from next week on I am done with that & try to finish both of my PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

Replace tag components across how-to and research
2 participants