Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live tests/v5 #11074

Closed
wants to merge 8 commits into from
Closed

Live tests/v5 #11074

wants to merge 8 commits into from

Conversation

victorjulien
Copy link
Member

#11073, plus a libpcap live job based on the af-packet script.

In the default config iface bypass support is not enabled,
and storage API not initialized for it. Using it will lead to a crash.

This commit first checks if the device storage API is initialized.

Bug: OISF#7022.
Commands would leave use_cnt incremented, never decrementing them. This
would lead to a asserting triggering at shutdown.

Bug: OISF#7020.
To increase code coverage.
@catenacyber
Copy link
Contributor

Should the old PRs get closed ?

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (cb56752) to head (cf0e4d5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11074      +/-   ##
==========================================
+ Coverage   83.63%   84.06%   +0.43%     
==========================================
  Files         922      922              
  Lines      250321   250324       +3     
==========================================
+ Hits       209349   210428    +1079     
+ Misses      40972    39896    -1076     
Flag Coverage Δ
fuzzcorpus 64.20% <0.00%> (-0.03%) ⬇️
livemode 19.69% <100.00%> (+1.26%) ⬆️
pcap 46.45% <0.00%> (?)
suricata-verify 62.74% <0.00%> (-0.02%) ⬇️
unittests 62.26% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -0,0 +1,155 @@
#!/bin/bash

# Script to test live IDS capabilities for OCAO. Starts a ping, starts suricata,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats OCAO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, meant to say "PCAP"

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 20620

This was referenced May 15, 2024
@victorjulien
Copy link
Member Author

replaced by #11075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants