Detect negated content absent buffer 2224 v12.11 #11070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6575 Multi buffers keywords now use a single registration function DetectAppLayerMultiRegister with a GetBuffer argument. This GetBuffer function pointer is similar to the ones used by single-buffer keyword, except that it takes an additional parameter which is the index of the buffer to get. Under the hood, an anonymous union between these 2 functions pointers types is used. In the end, this deduplicates code, especially the calls to DetectEngineContentInspection
This was referenced May 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11070 +/- ##
==========================================
- Coverage 83.63% 78.55% -5.08%
==========================================
Files 922 922
Lines 250321 249736 -585
==========================================
- Hits 209349 196190 -13159
- Misses 40972 53546 +12574
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 20627 |
|
Rebased in #11117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6575
Describe changes:
#11067 with setting of
buffer->flags = DETECT_CI_FLAGS_SINGLE;for all keywordsThis is required for #10334