Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main-7.0.x backport of JA4 #11048

Closed
wants to merge 4 commits into from
Closed

main-7.0.x backport of JA4 #11048

wants to merge 4 commits into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #11044
Backport JA4 changes

Link to redmine ticket: 7010

Describe changes:

Updates:

  • Fixed commit issue

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_BRANCH=OISF/suricata-verify#1825

satta and others added 4 commits May 9, 2024 08:03
@satta @jlucovsky
suricata: initialize feature tracking earlier
194046a 
This gives app layer code a chance to access feature
information.

(cherry picked from commit 32f23b6)
@satta @jlucovsky
ja3: make feature compile time configurable
a0fa481 
(cherry picked from commit 9d0db71)
@satta @jlucovsky
ja4: implement for TLS and QUIC
085e725 
Ticket: OISF#6379
(cherry picked from commit 120313f)
@jlucovsky
tests/ja4: config message when ja4 auto enabled
7a74da9 
Issue: 7010

This commit displays a config message when JA4 is enabled due to rule
usage.
@jlucovsky jlucovsky mentioned this pull request May 9, 2024
Closed
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 20551

@catenacyber catenacyber marked this pull request as draft May 14, 2024 14:21
@catenacyber
Copy link
Contributor

Setting it to draft until CI is green by rebasing over the next version of main7 with the rust fixes

@jlucovsky jlucovsky marked this pull request as ready for review May 15, 2024 13:23
@jlucovsky jlucovsky mentioned this pull request May 23, 2024
Open
@jlucovsky
Copy link
Contributor Author

Continued in #11129

@jlucovsky jlucovsky closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber Awaiting requested review from catenacyber catenacyber is a code owner

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@jlucovsky @suricata-qa @catenacyber @satta