detect/lua: don't treat a crashed script as no match - v3 #11045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a rule script crashed, the return value was treated as a no match. This would make a negation of the rule match and alert. Instead cleanup and exit early if the rule script crashed and don't run negation logic. A stat, detect.lua_errors has been added to count how many times a script crashes. Also consolidates the running of the Lua script and return value handling to a common function. Bug: OISF#6940
- remove unused headers - cleanup/rename flags
jasonish
force-pushed
the
lua-rule-errors/v3
branch
from
11b6254
to
9e5339d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11045 +/- ##
==========================================
+ Coverage 80.63% 80.66% +0.02%
==========================================
Files 922 922
Lines 250137 250138 +1
==========================================
+ Hits 201699 201767 +68
+ Misses 48438 48371 -67
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time.
Pipeline 20546 |
|
Information: ERROR: QA failed on SURI_TLPR1_suri_time.
Pipeline 20547 |
jufajardini
reviewed
May 10, 2024
|
Git message still talks about |
|
Looks good otherwise. |
catenacyber
reviewed
May 14, 2024
| @@ -1227,6 +1227,9 @@ typedef struct DetectEngineThreadCtx_ { | |||
| AppLayerDecoderEvents *decoder_events; | |||
| uint16_t events; | |||
|
|
|||
| /** stats id for lua rule errors */ | |||
| uint16_t lua_rule_errors; | |||
There was a problem hiding this comment.
this is the count id
side thought: we should probably use a dedicated type for it
There was a problem hiding this comment.
this is the count id
Thanks Victor :-)
|
Why is CI so red ? |
|
Continued at #11083. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a rule script crashed, the return value was treated as a no
match. This would make a negation of the rule match and alert.
Instead cleanup and exit early if the rule script crashed and don't
run negation logic.
A stat, detect.lua_errors has been added to count how many times a
script crashes.
Also consolidates the running of the Lua script and return value
handling to a common function.
Bug: https://redmine.openinfosecfoundation.org/issues/6940
SV_BRANCH=OISF/suricata-verify#1826