use cookie to ensure write to a valid rule dir #302

inashivb · 2022-03-24T11:50:03Z

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/2691

Previous PR: #157

Changes since v1:
Entirely revamped. Used cookie approach suggested by Jason on Redmine

Known TODOs:

Same needs to be done for merged rule file

inashivb · 2022-03-24T11:55:13Z

suricata/update/main.py

+    if os.path.exists(directory):
+        if not os.path.exists(cookie_path) and os.listdir(directory):
+            logger.error("{} -- doesn't look like a suricata-update rule directory".format(directory))
+            sys.exit(1)


@jasonish do you think this is as per your expectations?
Questions:

How do we ensure that this does not break the current setups? Because we don't have a cookie already in the rule dir.

Is checking for dir good enough for determining "first run"?

Should the cookie be in say <prefix>/suricata or <prefix>/suricata/rules

use cookie to ensure write to a valid rule dir

90ba27f

inashivb commented Mar 24, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use cookie to ensure write to a valid rule dir #302

use cookie to ensure write to a valid rule dir #302

inashivb commented Mar 24, 2022 •

edited

inashivb Mar 24, 2022

use cookie to ensure write to a valid rule dir #302

Are you sure you want to change the base?

use cookie to ensure write to a valid rule dir #302

Conversation

inashivb commented Mar 24, 2022 • edited

inashivb Mar 24, 2022

Choose a reason for hiding this comment

inashivb commented Mar 24, 2022 •

edited