Skip to content

Commit

Permalink
Final edits for cran submission
Browse files Browse the repository at this point in the history
This commit adds comments for the cran submission and schedules github actions to run once a week.
  • Loading branch information
Clair Blacketer committed Feb 2, 2024
1 parent 3874edd commit fac08df
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
extras/*
docs/*
rmd/*
^CRAN-SUBMISSION$
^cran-comments\.md$
2 changes: 2 additions & 0 deletions .github/workflows/R_CMD_check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ on:
pull_request:
branches:
- '**'
schedule:
- cron: '0 19 * * 0' # every Sunday at 7pm UTC

name: R-CMD-check

Expand Down
3 changes: 3 additions & 0 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Version: 0.2.0
Date: 2024-01-31 19:11:21 UTC
SHA: 55c4d7a934e0c85d64503a89326cf7454209421a
10 changes: 10 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
## R CMD check results

* This is a new release

# Update based on reviewer feedback
- turned off tests when environment variables are not set

0 errors | 0 warnings | 1 note


3 changes: 2 additions & 1 deletion tests/testthat/test-executeDdl.R
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

# connection based tests required environment variables be configured
test_that("CommonDataModel Execution Test", {
if (Sys.getenv("CDM5_POSTGRESQL_SERVER") != "") {
Expand All @@ -22,7 +23,6 @@ test_that("CommonDataModel Execution Test", {
expect_error(disconnect(con), NA)
})


for (cdmVersion in listSupportedVersions()) {
test_that(paste("DDL", cdmVersion, "runs on", dbms), {
dropAllTablesFromSchema(connectionDetails, cdmDatabaseSchema)
Expand Down Expand Up @@ -61,3 +61,4 @@ test_that("CommonDataModel Execution Test", {
message("Skipping driver setup because environmental variables not set")
}
})

0 comments on commit fac08df

Please sign in to comment.