python: move remaining projects to pyproject.toml #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move packager to a pyproject.toml project. Removes the legacy behavior of calling python on setup.py, which is no longer the advised way of creating python packages. Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
anandaravuri
previously approved these changes
Mar 29, 2023
Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
anandaravuri
previously approved these changes
Apr 3, 2023
anandaravuri
previously approved these changes
Apr 4, 2023
Pull Request Test Coverage Report for Build 4630681308
💛 - Coveralls |
anandaravuri
previously approved these changes
Apr 4, 2023
Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
tswhison
changed the title
In support of legacy pip versions that don't respect pyproject.toml, some portion of the setup.py file is still required. Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
anandaravuri
approved these changes
Apr 7, 2023
|
I checked that the venv generated by the OFS FIM build still works properly on SJ. Looks fine. |
|
I plan to merge this to master on Monday so as not to break anything over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all python projects to pyproject.toml projects. Removes the legacy behavior of calling python on setup.py, which is no longer the advised way of creating python packages. See https://peps.python.org/pep-0517/