[16.0][FIX] web_field_tooltip: access to ir.model and ir.model.fields… #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwillig
suggested changes
May 15, 2024
| rec.env["ir.model.fields"].sudo().browse(rec.proxy_field_id.id) | ||
| if rec.proxy_field_id | ||
| else False | ||
| ) |
There was a problem hiding this comment.
same here with the field
|
|
||
| id = fields.Integer() | ||
| name = fields.Char(string="Model Name") | ||
| description = fields.Char(translate=True) |
There was a problem hiding this comment.
the SQL view won't handle the translate properly. So maybe a compute would be better here. All fields should be readonly too.
There was a problem hiding this comment.
The SQL view extract the jsonb so declaring the field translate=True enable the Odoo mechanism to handle it properly.
benwillig
reviewed
May 15, 2024
| _logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| @openupgrade.migrate(use_env=True) |
There was a problem hiding this comment.
I don't think we should use openupgrade only for two simple queries.
glitchov
force-pushed
the
16.0-fix-web_field_tooltip_ir_model_access-hda
branch
from
1ae099c
to
70efc5a
Compare
ThomasBinsfeld
approved these changes
May 16, 2024
benwillig
approved these changes
May 16, 2024
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at aa0d32a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are not admin you can't create any new tooltip as a tooltips manager because of the access to ir.model and ir.model.fields. Giving read access to this specific tooltip manager group seems to be acceptable.