[16.0][FIX] web_calendar_slot_duration: fixing behavior on slot duration #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yajo, |
yajo
changed the title
yajo
requested changes
May 13, 2024
Comment on lines
15
to
16
| this.env.searchModel.context.calendar_slot_duration && | ||
| this.env.searchModel.context.adapt_view_to_slot_duration |
There was a problem hiding this comment.
I don't understand this fix. Could you post some screenshots explaining the problem you're fixing here please? Also, don't you think it would make sense to default to true for adapt_view_to_slot_duration?
There was a problem hiding this comment.
Hello @yajo
The adapt_view_to_slot_duration is to solve the way to display the calendar view.
If you check on my screen shot on description, If I put a slot_duration like 30m, on the calendar the view will be adapted to display slots 30min by 30min and IMO it's not very "beautiful".
And yes, I'm agreed with you about the default to true to not change the standard behavior .
imlopes
force-pushed
the
16.0-fix-slot-duration
branch
from
019ecf7
to
889f811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert all to float :
if we use a context like {'calendar_slot_duration': '01:30:00'} we will have on the backend a duration of 10 hour and 30 minutes instead of 1 hour and 30 minutes
And using a slot_duration > 1 hour, the calendar view will be adapted to the slot duration but has not a good presentation.
So I'm adding a possibility to adapt or not the calendar view using
adapt_view_to_slot_durationon the context too.