Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [IMP] web_responsive showing main menu when no application is selected #2816

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0] [IMP] web_responsive showing main menu when no application is selected #2816

wants to merge 1 commit into from

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented May 6, 2024 •
edited

See

menu

@OCA-git-bot
Copy link
Contributor

Hi @Tardo, @SplashS,
some modules you are maintaining are being modified, check this out!

@Tardo
Copy link
Member

Tardo commented May 7, 2024

Code OK. But idk how to "solve" the tests...

@eLBati eLBati marked this pull request as draft May 7, 2024 15:18
@eLBati eLBati marked this pull request as ready for review May 7, 2024 16:13
Jaimermaccione
Jaimermaccione approved these changes May 8, 2024
View reviewed changes
Copy link

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Functional review on runboat

pedrobaeza
pedrobaeza requested changes May 8, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be something optional.

@eLBati
Copy link
Member Author

eLBati commented May 24, 2024

Hi @pedrobaeza , what problem do you see in setting this as default behavior o the module?
Thanks!

@pedrobaeza
Copy link
Member

For several reasons:

If you assure that there are no problems with points 2 and 3, then 1 can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

@Tardo Tardo Tardo approved these changes

@Jaimermaccione Jaimermaccione Jaimermaccione approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eLBati @OCA-git-bot @Tardo @pedrobaeza @Jaimermaccione