Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] web_company_color: UI improvements #2814

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][IMP] web_company_color: UI improvements #2814

wants to merge 1 commit into from

Conversation

ajaniszewska-dev
Copy link

@ajaniszewska-dev ajaniszewska-dev commented Apr 29, 2024 •
edited

  1. add field to control input bg color : before this change "button background color" was changing not only button's bg color but also input fields bg color.

@ajaniszewska-dev ajaniszewska-dev changed the title [14.0][IMP] web_company_color: add field to control input fields bg c… [14.0][IMP] web_company_color: add field to control input bg color Apr 29, 2024
@ajaniszewska-dev ajaniszewska-dev changed the title [14.0][IMP] web_company_color: add field to control input bg color [14.0][IMP] web_company_color: UI improvements Apr 30, 2024
JuMiSanAr
JuMiSanAr approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@JuMiSanAr JuMiSanAr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
However, I'm assuming the previous color system was intended as is and someone might want to keep it, maybe this should go into its own module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuMiSanAr JuMiSanAr JuMiSanAr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajaniszewska-dev @JuMiSanAr