Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] web_select_all_companies: Migration to 17.0 #2798

Open
wants to merge 17 commits into
base: 17.0
Choose a base branch
from

Conversation

yannoliv
Copy link

No description provided.

#: code:addons/web_select_all_companies/static/src/xml/switch_all_company_menu.xml:0
#, python-format
msgid "Select All Companies"
msgstr "Selecteer Alle Bedrijven"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add this to a nl.po file instead, because then, you will have translations for both nl and nl_BE. nl_BE will take nl as default.
(Also add empty line at the end)

@yannoliv yannoliv requested a review from Denim0202 April 22, 2024 06:54
@yannoliv
Copy link
Author

Hi, can you please review this PR? @santostelmo

Copy link
Contributor

@santostelmo santostelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot. Thank you LG

@OCA-git-bot
Copy link
Contributor

Hi @yannoliv. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@yannoliv
Copy link
Author

/ocabot migration web_select_all_companies

@OCA-git-bot
Copy link
Contributor

Sorry @yannoliv you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants