[16.0][IMP] web_timeline: Align to top instead of bottom #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tarteo, |
pedrobaeza
approved these changes
Apr 3, 2024
houzefa-abba
force-pushed
the
16.0-timeline-top
branch
from
c8985a0
to
d4bfe88
Compare
This avoids somewhat ugly very large "Unassigned" first row.
houzefa-abba
force-pushed
the
16.0-timeline-top
branch
from
d4bfe88
to
08139ea
Compare
dhx
approved these changes
May 21, 2024
|
This PR has the |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 6354d68. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids somewhat ugly very large "Unassigned" first row.
See doc on https://visjs.github.io/vis-timeline/docs/timeline/ > "orientation" setting:
Since our view always covers 100% height, the "bottom" default setting was producing that large first row.
This could be a per-view setting; I didn't add a setting for now as I believe this top-aligned behavior is always desirable (as far as I could see when showing this around, at least). I can add a setting if you feel it would be needed.
Before
After