Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] fs_attachment: fix constraint #363

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][FIX] fs_attachment: fix constraint #363

wants to merge 1 commit into from

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Apr 25, 2024

Fixes #362

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@astirpe astirpe mentioned this pull request Apr 25, 2024
Open
lmignon
lmignon reviewed Apr 25, 2024
View reviewed changes
Copy link
Sponsor Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astirpe Thank you for the proposal. Can you add some comments into the code to explain why it's done as is and do the same into the commit message.

@astirpe
[FIX] fs_attachment: fix constraint
48fa000 
The method _check_force_db_for_default_attachment_rules() encountered issues when used with a constraints() decorator due to the computed field use_as_default_for_attachments, which is not stored in the database. This fix consists in replacing the constraints() decorator with a directly invoked method.
@astirpe
Copy link
Member Author

astirpe commented Apr 26, 2024

@lmignon done, could you check?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@gurneyalex
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-363-by-gurneyalex-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 21, 2024
@OCA-git-bot
Merge PR #363 into 17.0
734cbd5 
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-363-by-gurneyalex-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@gurneyalex gurneyalex gurneyalex approved these changes

@gbrito gbrito gbrito approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@astirpe @OCA-git-bot @gurneyalex @lmignon @gbrito