Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] fs_attachment: No crash on missing file #361

Merged
merged 1 commit into from May 10, 2024

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Apr 22, 2024

When trying to get access to files stored into an external filesystem, don't crash if the files cannot be accessed. This is necessary to avoid blocking Odoo's operation if an external system is not accessible.

@lmignon lmignon force-pushed the 16.0-no-crach-on-read branch 2 times, most recently from fa68412 to 6b154f5 Compare April 22, 2024 08:23
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

When trying to get access to files stored into an external filesystem, don't crash if the files cannot be accessed. This is necessary to avoid blocking Odoo's operation if an external system is not accessible.
@lmignon
Copy link
Sponsor Contributor Author

lmignon commented May 10, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-361-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 696d26d into OCA:16.0 May 10, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ae79d68. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-no-crach-on-read branch May 10, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants