[ADD][16.0] fs_storage_backup #309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarteo
force-pushed
the
16-add-fs_storage_backup
branch
5 times, most recently
from
e318188
to
24e24a8
Compare
lmignon
approved these changes
Dec 15, 2023
lmignon
reviewed
Dec 15, 2023
| tools.config["list_db"] = True | ||
| db.dump_db( | ||
| self.env.cr.dbname, | ||
| backup_file.buffer, |
There was a problem hiding this comment.
What about memory consumption. Is the buffer a temporary file?
There was a problem hiding this comment.
Here buffer is a file-like for s3 default blocksize is 5242880
Run black [ADD] tests [FIX] Tests [FIX] Tests [ADD] Misconfig tests fixup Fixup
tarteo
force-pushed
the
16-add-fs_storage_backup
branch
from
24e24a8
to
43d209d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.