[15.0][IMP]stock_cycle_count: add auto complete and begin adjustments in cron #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnauCForgeFlow
force-pushed
the
15.0-imp-stock_cycle_count-user_and_date
branch
3 times, most recently
from
44d4221
to
4c963c0
Compare
ArnauCForgeFlow
force-pushed
the
15.0-imp-stock_cycle_count-user_and_date
branch
from
4c963c0
to
90fc098
Compare
ArnauCForgeFlow
force-pushed
the
15.0-imp-stock_cycle_count-user_and_date
branch
3 times, most recently
from
ee770b8
to
e51735b
Compare
ArnauCForgeFlow
force-pushed
the
15.0-imp-stock_cycle_count-user_and_date
branch
from
e51735b
to
ff64074
Compare
ArnauCForgeFlow
force-pushed
the
15.0-imp-stock_cycle_count-user_and_date
branch
from
ff64074
to
09edb8a
Compare
rousseldenis
reviewed
May 3, 2024
| @@ -76,6 +62,27 @@ def _domain_cycle_count_candidate(self): | |||
| ("location_id", "in", self.location_ids.ids), | |||
| ] | |||
|
|
|||
| def _calculate_inventory_accuracy(self): | |||
| for inv in self: | |||
| sml = self.env["stock.move.line"].search( | |||
There was a problem hiding this comment.
Mmmh, IMHO this has to be refined has multiple searches will be done...
ArnauCForgeFlow
force-pushed
the
15.0-imp-stock_cycle_count-user_and_date
branch
2 times, most recently
from
23f01a4
to
e14e801
Compare
ArnauCForgeFlow
force-pushed
the
15.0-imp-stock_cycle_count-user_and_date
branch
4 times, most recently
from
09c6757
to
be2ca4a
Compare
JoanSForgeFlow
force-pushed
the
15.0-imp-stock_cycle_count-user_and_date
branch
from
be2ca4a
to
28c1195
Compare
| inv.action_state_to_in_progress() | ||
| try: | ||
| inv.action_state_to_in_progress() | ||
| except Exception as e: |
There was a problem hiding this comment.
Isn't it a too broad Exception ?
Moreover, shouldn't we manage the exception in a more elegant manner than 'just' logging ?
There was a problem hiding this comment.
Hey @rousseldenis
You might be right. I implemented it this way because we don't want the cron job to stop running due to a validation error from a location that already has an inventory adjustment in progress.
Do you have any suggestions for a better approach?
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1995
This PR include the following improvements: