New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD][16.0] developer_menu module #878
Conversation
bealdav
commented
May 8, 2024
•
edited
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to move menu entries into the new développer menu, instead of duplicate.
Otherwise, all things will be duplicated. (In the search feature of web_responsive module )
developer_menu/views/menu_view.xml
Outdated
<menuitem | ||
id="conf_tech" | ||
parent="base.menu_administration" | ||
name="🧰" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no images in menu item in odoo and OCA modules. Introducing it breaks that implicit rule.
Also an image is less accessible and doens't brings any advantages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not an image, it's a unicode char like emoji. Odoo use emojis in some context.
We are no more in ascii or latin world ;-)
The purpose of OCA is not to always follow the Odoo way in all contexts : there are many examples. That's the key for innovation
The advantage is not to be more accessible, it's to be more compact (in settings apps which is not practical), it's intentional.
This module is not supposed to be installed on production instance as its name tells then no confusion for users.
I think it's better to move menu entries into the new développer menu, instead of duplicate.
I don't think on my side, it's a matter of taste but if someone miss this shortcut , it expects to find orginal menus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The advantage is not to be more accessible
Well, i'm not blind and i'm not very aware of such topic. But IFAIK, set an emoji as the name of an item is not accessible for blind people. Also it can not be searched...
Généraly, using image introduces a lot of matter of taste. For exemple, the current wallet image doesn't mean "configuration" for me, but for you it does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, what do you suggest instead of this wallet aka tool box ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Développer"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This i not a wallet but https://emojipedia.org/fr/bo%C3%AEte-%C3%A0-outils
Are you agree with 🧰 Dev
? Easy to find because of color and meaningful and short then happy with responsive.
Well. I don't understand this module, and I find the design not in the spirit of odoo. (Duplicating entries, use icon in menu, ...) Regards |
Thanks for your final words. However it seems your requested blocked merge with change requested. Is it possible to remove request and consider it as comment ? Thanks a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well and providing direct access to the main technical menus required for functional usage. BTW, the use of icons becomes quite intuitive fairly quickly.
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 389fd38. Thanks a lot for contributing to OCA. ❤️ |