Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ENH] base_tier_validation, add Notify Reviewers by Approve Sequence #854

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][ENH] base_tier_validation, add Notify Reviewers by Approve Sequence #854

wants to merge 1 commit into from
+60 −2

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented Apr 11, 2024 •
edited

This enhancement add another option for Tier Definition.

Notify reviewer by sequence

Use with 'Approve by sequence' to ensure that, the next reviewer will be notified only when he/she is the next approver in sequence.

Note:

  • This works independently from 'Notify reviewers on creation', so it shouldn't be used together.
  • This method will not add subscription and will not notify any other followers except the reviewer.

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@kittiu kittiu force-pushed the 15.0-enh-base_tier_validation-notify_by_sequence branch 2 times, most recently from 02ecdad to 0357727 Compare April 11, 2024 10:44
@kittiu
Copy link
Member Author

kittiu commented Apr 11, 2024

cc @ps-tubtim

@kittiu kittiu force-pushed the 15.0-enh-base_tier_validation-notify_by_sequence branch from 0357727 to 8ef4eff Compare April 11, 2024 11:05
ps-tubtim
ps-tubtim approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@ps-tubtim ps-tubtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test: Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-tubtim ps-tubtim ps-tubtim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kittiu @OCA-git-bot @ps-tubtim