[17.0][RFC] base_tier_validation: remove unused code #824
Conversation
|
Hi @LoisRForgeFlow, |
bosd
force-pushed
the
17.0-imp-clean-base_tier_validation
branch
2 times, most recently
from
359fcd6
to
0b71de2
Compare
bosd
force-pushed
the
17.0-imp-clean-base_tier_validation
branch
from
0b71de2
to
ca73f1c
Compare
|
the function The remaining code might need some refactoring 🤔 @celm1990 @LoisRForgeFlow |
| @@ -15,7 +15,6 @@ def review_user_count(self): | |||
| domain = [ | |||
| ("status", "=", "pending"), | |||
| ("can_review", "=", True), | |||
| ("id", "in", self.env.user.review_ids.ids), | |||
There was a problem hiding this comment.
Had to remove this, to make the tests pass.
I'm not seeing in the code where the values to review_ids are written.
(expect for the no longer needed lines in the test)
self.assertTrue(self.test_user_1.get_reviews({"res_ids": review.ids}))
With no valid ID assigned it broke the tests..
(Filtering on the user ID is done, a couple llines below.)
There was a problem hiding this comment.
Maybe some more refactoring is needed on the domain. (Or an alternative function to write review_ids) I'm not sure..
| @@ -24,7 +23,7 @@ def review_user_count(self): | |||
| if reviews: | |||
| records = ( | |||
| self.env[model] | |||
| .with_user(self.env.user) | |||
| .sudo() | |||
There was a problem hiding this comment.
Without this. There was an error in the tests. The user is not allowed to acces SO records.
remove the code, which was needed for the review widget pre V16.