[16.0][IMP] module_change_auto_install: also allow using environment variables #2811

vincent-hatakeyama · 2024-01-18T15:44:01Z

No description provided.

OCA-git-bot · 2024-01-18T15:44:14Z

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

legalsylvain

makes sense !

OCA-git-bot · 2024-04-19T13:43:12Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain

Could you add an exemple of how to use environment variable in the configure section, specially for the dict syntax ?

vincent-hatakeyama · 2024-05-13T13:01:01Z

I added information on how to use the environment variables too.

legalsylvain · 2024-05-13T18:07:02Z

Thanks !

/ocabot merge minor

OCA-git-bot · 2024-05-13T18:07:26Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2811-by-legalsylvain-bump-minor, awaiting test results.

Signed-off-by legalsylvain

OCA-git-bot · 2024-05-13T18:13:55Z

@legalsylvain The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name server-tools --branch 16.0 --addons-dir /tmp/tmpia9n936m --commit failed with output:

/tmp/tmpia9n936m/module_change_auto_install/README.rst:82: (ERROR/3) Error in "code-block" directive:
unknown option: "emphasize-lines".

.. code-block:: cfg
   :emphasize-lines: 1

    server_wide_modules = web,module_change_auto_install

    modules_auto_install_disabled =
        partner_autocomplete,
        iap,
        mail_bot

    modules_auto_install_enabled =
        web_responsive:web,
        base_technical_features,
        disable_odoo_online,
        account_usability

Traceback (most recent call last):
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2142, in run_directive
    self.parse_directive_block(indented, line_offset,
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2194, in parse_directive_block
    options, arg_block = self.parse_directive_options(
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2230, in parse_directive_options
    raise MarkupError(data)
docutils.parsers.rst.states.MarkupError: unknown option: "emphasize-lines"

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
    load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 422, in publish_file
    output, publisher = publish_programmatically(
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 722, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 234, in publish
    self.document = self.reader.read(self.source, self.parser,
  File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 70, in read
    self.parse()
  File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 76, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/__init__.py", line 184, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 169, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 3024, in text
    self.section(title.lstrip(), source, style, lineno + 1, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2785, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2355, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2367, in explicit_construct
    return method(self, expmatch)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2104, in directive
    return self.run_directive(
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2145, in run_directive
    error = self.reporter.error(
  File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 231, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 197, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmpia9n936m/module_change_auto_install/README.rst:82: (ERROR/3) Error in "code-block" directive:
unknown option: "emphasize-lines".

.. code-block:: cfg
   :emphasize-lines: 1

    server_wide_modules = web,module_change_auto_install

    modules_auto_install_disabled =
        partner_autocomplete,
        iap,
        mail_bot

    modules_auto_install_enabled =
        web_responsive:web,
        base_technical_features,
        disable_odoo_online,
        account_usability

legalsylvain · 2024-05-13T19:43:34Z

@vincent-hatakeyama could you take a look ?

vincent-hatakeyama · 2024-05-17T09:47:48Z

@vincent-hatakeyama could you take a look ?

I’ve remove the rst that seems to cause trouble.

legalsylvain

/ocabot merge minor

OCA-git-bot · 2024-05-17T09:53:23Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2811-by-legalsylvain-bump-minor, awaiting test results.

Signed-off-by legalsylvain

OCA-git-bot · 2024-05-17T09:59:41Z

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2811-by-legalsylvain-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

This addon define a new model 'fs.storage' used to get access to a filesystem storage (ftp, sftp, s3, azure, ...) through an unified interface provided by the 'fsspec' python library (https://filesystem-spec.readthedocs.io/en/latest)

legalsylvain · 2024-05-17T12:50:56Z

@vincent-hatakeyama : waiting for OCA/storage#372

SirAionTech · 2024-05-28T14:47:48Z

@vincent-hatakeyama : waiting for OCA/storage#372

@legalsylvain it is merged

legalsylvain · 2024-05-28T14:48:59Z

Thanks !

/ocabot merge patch

OCA-git-bot · 2024-05-28T14:49:20Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2811-by-legalsylvain-bump-patch, awaiting test results.

Signed-off-by legalsylvain

SirAionTech

Thanks for the PR!
Only code review

legalsylvain · 2024-05-28T15:22:43Z

/ocabot rebase

OCA-git-bot · 2024-05-28T15:22:49Z

@legalsylvain The rebase process failed, because command git push --force xcgd tmp-pr-2811:16.0-module_change_auto_install-add-env-var failed with output:

remote: Permission to xcgd/server-tools.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/xcgd/server-tools/': The requested URL returned error: 403

legalsylvain · 2024-05-28T15:23:15Z

@vincent-hatakeyama could you rebase ?

module_change_auto_install/readme/CONFIGURE.rst

vincent-hatakeyama · 2024-05-28T15:29:22Z

@vincent-hatakeyama could you rebase ?

I’ve rebased after removing the line emphasis.

OCA-git-bot · 2024-05-28T15:38:53Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain · 2024-05-28T18:58:34Z

/ocabot merge patch

OCA-git-bot · 2024-05-28T18:59:16Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2811-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot · 2024-05-28T19:06:15Z

Congratulations, your PR was merged at 311fe7e. Thanks a lot for contributing to OCA. ❤️

vincent-hatakeyama force-pushed the 16.0-module_change_auto_install-add-env-var branch from 596cbc9 to a82abee Compare January 18, 2024 15:46

vincent-hatakeyama marked this pull request as ready for review January 18, 2024 15:53

vincent-hatakeyama mentioned this pull request Mar 14, 2024

[13.0][IMP] module_change_auto_install: add env var #2885

Open

vincent-hatakeyama force-pushed the 16.0-module_change_auto_install-add-env-var branch from a82abee to f9cadb8 Compare March 14, 2024 15:32

legalsylvain approved these changes Mar 14, 2024

View reviewed changes

houzefa-abba approved these changes Apr 19, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 19, 2024

legalsylvain requested changes Apr 19, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Apr 19, 2024

vincent-hatakeyama force-pushed the 16.0-module_change_auto_install-add-env-var branch from f9cadb8 to be8e53a Compare May 13, 2024 12:58

OCA-git-bot added a commit that referenced this pull request May 13, 2024

Merge PR #2811 into 16.0

374e512

Signed-off-by legalsylvain

OCA-git-bot added the bot is merging ⏳ label May 13, 2024

OCA-git-bot removed the bot is merging ⏳ label May 13, 2024

vincent-hatakeyama force-pushed the 16.0-module_change_auto_install-add-env-var branch from be8e53a to 815fb43 Compare May 14, 2024 10:40

legalsylvain approved these changes May 17, 2024

View reviewed changes

OCA-git-bot added the approved label May 17, 2024

OCA-git-bot added a commit that referenced this pull request May 17, 2024

Merge PR #2811 into 16.0

d2266bc

Signed-off-by legalsylvain

OCA-git-bot added the bot is merging ⏳ label May 17, 2024

OCA-git-bot added a commit that referenced this pull request May 28, 2024

Merge PR #2811 into 16.0

bf5cc54

Signed-off-by legalsylvain

OCA-git-bot added the bot is merging ⏳ label May 28, 2024

SirAionTech approved these changes May 28, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

OCA-git-bot removed the bot is merging ⏳ label May 28, 2024

SirAionTech suggested changes May 28, 2024

View reviewed changes

module_change_auto_install/readme/CONFIGURE.rst Outdated Show resolved Hide resolved

OCA-git-bot removed the approved label May 28, 2024

[IMP] module_change_auto_install: also allow using environment variables

1fa1277

vincent-hatakeyama force-pushed the 16.0-module_change_auto_install-add-env-var branch from 815fb43 to 1fa1277 Compare May 28, 2024 15:27

SirAionTech approved these changes May 28, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels May 28, 2024

OCA deleted a comment from OCA-git-bot May 28, 2024

OCA-git-bot added the bot is merging ⏳ label May 28, 2024

OCA-git-bot merged commit 7bd2ba5 into OCA:16.0 May 28, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][IMP] module_change_auto_install: also allow using environment variables #2811

[16.0][IMP] module_change_auto_install: also allow using environment variables #2811

vincent-hatakeyama commented Jan 18, 2024

OCA-git-bot commented Jan 18, 2024

legalsylvain left a comment

OCA-git-bot commented Apr 19, 2024

legalsylvain left a comment

vincent-hatakeyama commented May 13, 2024

legalsylvain commented May 13, 2024

OCA-git-bot commented May 13, 2024

OCA-git-bot commented May 13, 2024

legalsylvain commented May 13, 2024

vincent-hatakeyama commented May 17, 2024

legalsylvain left a comment

OCA-git-bot commented May 17, 2024

OCA-git-bot commented May 17, 2024

legalsylvain commented May 17, 2024

SirAionTech commented May 28, 2024

legalsylvain commented May 28, 2024

OCA-git-bot commented May 28, 2024

SirAionTech left a comment

This comment was marked as resolved.

legalsylvain commented May 28, 2024

OCA-git-bot commented May 28, 2024

legalsylvain commented May 28, 2024

vincent-hatakeyama commented May 28, 2024

OCA-git-bot commented May 28, 2024

legalsylvain commented May 28, 2024

OCA-git-bot commented May 28, 2024

OCA-git-bot commented May 28, 2024

[16.0][IMP] module_change_auto_install: also allow using environment variables #2811

[16.0][IMP] module_change_auto_install: also allow using environment variables #2811

Conversation

vincent-hatakeyama commented Jan 18, 2024

OCA-git-bot commented Jan 18, 2024

legalsylvain left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 19, 2024

legalsylvain left a comment

Choose a reason for hiding this comment

vincent-hatakeyama commented May 13, 2024

legalsylvain commented May 13, 2024

OCA-git-bot commented May 13, 2024

OCA-git-bot commented May 13, 2024

legalsylvain commented May 13, 2024

vincent-hatakeyama commented May 17, 2024

legalsylvain left a comment

Choose a reason for hiding this comment

OCA-git-bot commented May 17, 2024

OCA-git-bot commented May 17, 2024

legalsylvain commented May 17, 2024

SirAionTech commented May 28, 2024

legalsylvain commented May 28, 2024

OCA-git-bot commented May 28, 2024

SirAionTech left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

legalsylvain commented May 28, 2024

OCA-git-bot commented May 28, 2024

legalsylvain commented May 28, 2024

vincent-hatakeyama commented May 28, 2024

OCA-git-bot commented May 28, 2024

legalsylvain commented May 28, 2024

OCA-git-bot commented May 28, 2024

OCA-git-bot commented May 28, 2024