11.0 mig mass editing #1048

jnegrete · 2017-11-11T18:29:14Z

No description provided.

…2m field.

…w when we define it, is why that I remove the tag type in the view to avoid that server shows us a warning

…=False

Fixes OCA#15 Check that `domain[2]` is `str` because in some cases it's an `int` and `list` operations don't work on `int`s.

This resulted in frontend searching for ` tree` view, which of course does not exist.

Without this patch, if you created a mass editing definition that included a *2many object and then opened the wizard, you got this exception: Uncaught TypeError: Cannot read property 'list' of undefined http://localhost/web/static/src/js/views/form_view.js:488 Traceback: TypeError: Cannot read property 'list' of undefined at http://localhost/web/static/src/js/views/form_view.js:488:30 at Function._.each._.forEach (http://localhost/web/static/lib/underscore/underscore.js:150:9) at http://localhost/web/static/src/js/views/form_view.js:486:19 at Function._.each._.forEach (http://localhost/web/static/lib/underscore/underscore.js:150:9) at Class._build_onchange_specs (http://localhost/web/static/src/js/views/form_view.js:473:11) at Class.do_onchange (http://localhost/web/static/src/js/views/form_view.js:523:18) at Array.<anonymous> (http://localhost/web/static/src/js/views/form_view.js:377:26) at fire (http://localhost/web/static/lib/jquery/jquery.js:3119:58) at Object.fireWith [as resolveWith] (http://localhost/web/static/lib/jquery/jquery.js:3231:49) at Object.<anonymous> (http://localhost/web/static/lib/jquery/jquery.js:3360:58)

* Made Mass Editing module v10 compatible * Mass Editing module v10 translations * Update ir_model_fields.py * [FIX] mass_editing v10 port openerp->odoo * [FIX] pep8 * [FIX] remove no-longer supported auto_refresh in view

* [FIX] View * [FIX] viewing in community

Without this fix, it is impossible to uninstall an addon that removes a model for which we had a `mass.object`.

yajo

Could you explain why are you removing all things related to ir.values?

Also, squash all translation-related commits together and fix Travis please.

yajo · 2017-11-13T09:44:52Z

mass_editing/__manifest__.py

    'author': 'Serpent Consulting Services Pvt. Ltd., '
              'Tecnativa, '
              'Odoo Community Association (OCA)',
    'contributors': [
        'Oihane Crucelaegui <oihanecrucelaegi@gmail.com>',
        'Serpent Consulting Services Pvt. Ltd. <support@serpentcs.com>',
-        'Jay Vora <jay.vora@serpentcs.com>'
+        'Jay Vora <jay.vora@serpentcs.com>',
+        'Juan Negrete <jnegrete@casasalce.com>'


Contributors nowadays go into README, this part can be dropped from here.

yajo · 2017-11-13T09:46:45Z

mass_editing/hooks.py

@@ -7,6 +6,5 @@ def uninstall_hook(cr, registry):
    cr.execute("""SELECT id FROM ir_act_window
               WHERE res_model = 'mass.editing.wizard'""")
    for res in cr.dictfetchall():
-        value = 'ir.actions.act_window,%s' % res.get('id')
-        cr.execute("DELETE FROM ir_values WHERE value = %s", (value, ))
+        cr.execute("DELETE FROM ir_act_window WHERE id = '%s'" % res.get('id'))


Is this needed? Doesn't Odoo by itself automatically remove tables when an addon is uninstalled?

Yes: Add a docstring on why.

No: remove it.

This query is a little bit.... well, not KISS. Just DELETE FROM ir_act_window WHERE res_model = 'mass.editing.wizard' and you're done

yajo · 2017-11-13T09:48:20Z

mass_editing/wizard/mass_editing_wizard.py

@@ -238,7 +238,7 @@ def create(self, vals):
                self._context.get('active_ids')):
            model_obj = self.env[self._context.get('active_model')]
            values = {}
-            for key, val in vals.items():
+            for key, val in list(vals.items()):


yajo · 2017-11-13T09:48:35Z

mass_editing/wizard/mass_editing_wizard.py

@@ -208,7 +208,7 @@ def fields_view_get(self, view_id=None, view_type='form', toolbar=False,
                            'colspan': '4',
                        })
            # Patch fields with required extra data
-            for field in all_fields.values():
+            for field in list(all_fields.values()):


…move list

jnegrete · 2017-11-13T23:20:42Z

Hello Jairo, ir.values doesn't exist in odoo v11.0 I add the query and remove list, they were added by 2to3 -wnj4 --no-diffs Regards. 2017-11-13 3:50 GMT-06:00 Jairo Llopis <notifications@github.com>:

…

***@***.**** requested changes on this pull request. Could you explain why are you removing all things related to ir.values? ------------------------------ In mass_editing/__manifest__.py <#1048 (comment)>: > 'author': 'Serpent Consulting Services Pvt. Ltd., ' 'Tecnativa, ' 'Odoo Community Association (OCA)', 'contributors': [ 'Oihane Crucelaegui ***@***.***>', 'Serpent Consulting Services Pvt. Ltd. ***@***.***>', - 'Jay Vora ***@***.***>' + 'Jay Vora ***@***.***>', + 'Juan Negrete ***@***.***>' Contributors nowadays go into README, this part can be dropped from here. ------------------------------ In mass_editing/hooks.py <#1048 (comment)>: > @@ -7,6 +6,5 @@ def uninstall_hook(cr, registry): cr.execute("""SELECT id FROM ir_act_window WHERE res_model = 'mass.editing.wizard'""") for res in cr.dictfetchall(): - value = 'ir.actions.act_window,%s' % res.get('id') - cr.execute("DELETE FROM ir_values WHERE value = %s", (value, )) + cr.execute("DELETE FROM ir_act_window WHERE id = '%s'" % res.get('id')) 1. Is this needed? Doesn't Odoo by itself automatically remove tables when an addon is uninstalled? - Yes: Add a docstring on why. - No: remove it. 2. This query is a little bit.... well, not KISS. Just DELETE FROM ir_act_window WHERE res_model = 'mass.editing.wizard' and you're done ------------------------------ In mass_editing/wizard/mass_editing_wizard.py <#1048 (comment)>: > @@ -238,7 +238,7 @@ def create(self, vals): self._context.get('active_ids')): model_obj = self.env[self._context.get('active_model')] values = {} - for key, val in vals.items(): + for key, val in list(vals.items()): why? ------------------------------ In mass_editing/wizard/mass_editing_wizard.py <#1048 (comment)>: > @@ -208,7 +208,7 @@ def fields_view_get(self, view_id=None, view_type='form', toolbar=False, 'colspan': '4', }) # Patch fields with required extra data - for field in all_fields.values(): + for field in list(all_fields.values()): why? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1048 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEhl6q3ymb_wyDkzn7LuvA6DCnbKJhK6ks5s2BD5gaJpZM4QaljY> .

yajo · 2017-11-14T09:08:13Z

mass_editing/__manifest__.py

@@ -9,8 +9,7 @@
    'contributors': [


Please remove the key and move contributors to README

CasVissers-360ERP · 2017-11-15T12:42:04Z

I ran a functional test everything worked fine untill I tried to edit some values:

TypeError: val is null

https://xxx.odoo.com/web/content/960-ac050f6/web.assets_backend.js:1245
Traceback:
_parseServerData/<@https://xxx.odoo.com/web/content/960-ac050f6/web.assets_backend.js:1245:545
_.forEach@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:12:558
_parseServerData@https://xxx.odoo.com/web/content/960-ac050f6/web.assets_backend.js:1245:288
_fetchRecord/<@https://xxx.odoo.com/web/content/960-ac050f6/web.assets_backend.js:1185:81
then/</</<@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:802:678
fire@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:796:281
fireWith@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:801:198
then/</</<@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:802:849
fire@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:796:281
fireWith@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:801:198
Deferred/</deferred[tuple[0]]@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:803:31
rpc/</<@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:3858:346
then/</</<@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:802:678
fire@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:796:281
fireWith@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:801:198
Deferred/</deferred[tuple[0]]@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:803:31
fire@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:796:281
fireWith@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:801:198
then/</</<@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:802:849
fire@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:796:281
fireWith@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:801:198
then/</</<@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:802:849
fire@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:796:281
fireWith@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:801:198
done@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:1192:86
callback@https://xxx.odoo.com/web/content/906-d57f445/web.assets_common.js:1212:15

jnegrete · 2017-11-15T23:11:00Z

Hi Cas Vissers, Encontré un problema con los campos computados (like standard_price), puede ser tu caso, prueba con el nuevo cambio 2017-11-15 6:42 GMT-06:00 Cas Vissers <notifications@github.com>:

…

I ran a functional test everything worked fine untill I tried to edit some values: `Fout: TypeError: val is null https://vitamineenzo.odoo.com/web/content/960-ac050f6/web. assets_backend.js:1245 Traceback: ***@***.***://vitamineenzo.odoo.com/web/ content/960-ac050f6/web.assets_backend.js:1245:545 ***@***.***://vitamineenzo.odoo.com/web/content/906-d57f445/web. assets_common.js:12:558 ***@***.***://vitamineenzo.odoo.com/web/ content/960-ac050f6/web.assets_backend.js:1245:288 ***@***.***://vitamineenzo.odoo.com/web/content/960-ac050f6/web. assets_backend.js:1185:81 ***@***.***://vitamineenzo.odoo.com/web/content/906-d57f445/web. assets_common.js:802:678 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:796:281 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:801:198 ***@***.***://vitamineenzo.odoo.com/web/content/906-d57f445/web. assets_common.js:802:849 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:796:281 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:801:198 ***@***.***://vitamineenzo.odoo.com/ web/content/906-d57f445/web.assets_common.js:803:31 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:3858:346 ***@***.***://vitamineenzo.odoo.com/web/content/906-d57f445/web. assets_common.js:802:678 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:796:281 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:801:198 ***@***.***://vitamineenzo.odoo.com/ web/content/906-d57f445/web.assets_common.js:803:31 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:796:281 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:801:198 ***@***.***://vitamineenzo.odoo.com/web/content/906-d57f445/web. assets_common.js:802:849 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:796:281 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:801:198 ***@***.***://vitamineenzo.odoo.com/web/content/906-d57f445/web. assets_common.js:802:849 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:796:281 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:801:198 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:1192:86 ***@***.***://vitamineenzo.odoo.com/web/content/906- d57f445/web.assets_common.js:1212:15` — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1048 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEhl6tZh8yPnz1ZLYeHVspfnH3bvN1Eaks5s2twlgaJpZM4QaljY> .

yajo · 2017-11-16T08:05:02Z

Please remove cd3c87e, it was better before. If any computed method fails with that, it should be fixed in the computed method, not there.

OTOH, @CasVissers' logs are JS logs, not Python logs, so there's a high chance that the problem is in the client side.

As always, those logs are not in ?debug=assets mode, so they are almost completely useless. Can you switch to that mode and paste the good logs please @CasVissers?

RoelAdriaans · 2017-11-17T10:45:19Z

Shoudn't this be moved to https://github.com/OCA/server-ux/ as per https://docs.google.com/spreadsheets/d/1Xg95cW4TFMf_Lo5i_CZC_qOOfN8RgxPRc0LJTLTkdUI/edit?usp=sharing ( From issue #1008 )

pedrobaeza · 2017-11-17T10:47:05Z

Yeah!

yajo · 2017-11-17T10:55:25Z

True, closing. Reopen there please.

SerpentCS and others added 30 commits November 10, 2017 09:42

[ADD] Added mass_editing module compatible to version 7.0

6a99a45

[REVERT]

c26a247

[ADD] Added the module mass_editing with OpenERPv7 compatability

4d2237a

[ADD/IMP] mass_editing : Added ChangeLog file and copyright info

2ba32e6

[IMP] mass_editing : Improved typos and did some refactoring

8f3744b

[FIX] More fixes landed

9a982e5

Mass editing fixes for security access

6b542c1

[IMP] mass_editing: Corrections based on the merge comments

0d6bcfe

[IMP] mass_editing: Improved the code based on error log.

440b5bd

[IMP] mass_editing: Improved the code based on error log.

20aea0c

[IMP] mass_editing: Added _('') for constraint message.

1b0dc31

[ENH] Transformed mass.object's model_list char field into a proper m…

409ad6f

…2m field.

[IMP] Added one2many handling

1d64386

Add spanish translation and translation template.

219a1dc

[IMP] In 7.0 version of OpenERP it is unnecessary put the type of vie…

e4ddd50

…w when we define it, is why that I remove the tag type in the view to avoid that server shows us a warning

Launchpad automatic translations update.

94a39bd

Launchpad automatic translations update.

57e20d5

Generate .pot files

d5cfaee

Launchpad automatic translations update.

edafcb9

Launchpad automatic translations update.

363ad09

Launchpad automatic translations update.

fd11bcd

Launchpad automatic translations update.

209e6e6

Launchpad automatic translations update.

696ad1a

Launchpad automatic translations update.

3151ad6

[REF] 'mass_editing': flake8.

471ec2d

move all modules to __unported__ on master branch and set installable…

98db758

…=False

[ADD] Migrated <mass_editing> for Odoo

d8c3460

[MOD] Some changes

5559d9a

[MOD] Splitted mass_editing.py into two files

92e822f

Tighten type check in domain

7c6244f

Fixes OCA#15 Check that `domain[2]` is `str` because in some cases it's an `int` and `list` operations don't work on `int`s.

bealdav and others added 14 commits November 10, 2017 09:42

FIX warning in mass editing module when read (OCA#741)

920f027

OCA Transbot updated translations from Transifex

0e7f355

OCA Transbot updated translations from Transifex

47b6ed6

[FIX][mass_editing] Remove view mode space

edd3283

This resulted in frontend searching for ` tree` view, which of course does not exist.

OCA Transbot updated translations from Transifex

b5863a7

OCA Transbot updated translations from Transifex

b322fda

OCA Transbot updated translations from Transifex

0c360be

OCA Transbot updated translations from Transifex

e8f27db

OCA Transbot updated translations from Transifex

c8dfc4f

[FIX] mass_editing : bug in view (OCA#906)

9da6d53

* [FIX] View * [FIX] viewing in community

[FIX][mass_editing] Allow to delete models

3cf7eb4

Without this fix, it is impossible to uninstall an addon that removes a model for which we had a `mass.object`.

[MIG] mass_editing: Migration to 11.0

275d0fb

yajo requested changes Nov 13, 2017

View reviewed changes

yajo added the needs review label Nov 13, 2017

yajo added this to the 11.0 milestone Nov 13, 2017

[FIX] mass_editing: fix uninstall_hook, remove Juan from manifest, re…

da4cacc

…move list

yajo requested changes Nov 14, 2017

View reviewed changes

mass_editing/__manifest__.py Outdated

@@ -9,8 +9,7 @@

'contributors': [

Copy link

Member

yajo Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the key and move contributors to README

[IMP] mass_editing: move contributors to readme

e33e285

jnegrete force-pushed the 11.0-mig-mass_editing branch from cd3c87e to e33e285 Compare November 16, 2017 18:13

yajo closed this Nov 17, 2017

RoelAdriaans mentioned this pull request Nov 24, 2017

11.0 mig mass editing OCA/server-ux#5

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

11.0 mig mass editing #1048

11.0 mig mass editing #1048

jnegrete commented Nov 11, 2017

yajo left a comment •

edited

yajo Nov 13, 2017

yajo Nov 13, 2017

yajo Nov 13, 2017

yajo Nov 13, 2017

jnegrete commented Nov 13, 2017 via email

yajo Nov 14, 2017

CasVissers-360ERP commented Nov 15, 2017 •

edited

jnegrete commented Nov 15, 2017 via email

yajo commented Nov 16, 2017

RoelAdriaans commented Nov 17, 2017

pedrobaeza commented Nov 17, 2017

yajo commented Nov 17, 2017

11.0 mig mass editing #1048

11.0 mig mass editing #1048

Conversation

jnegrete commented Nov 11, 2017

yajo left a comment • edited

Choose a reason for hiding this comment

yajo Nov 13, 2017

Choose a reason for hiding this comment

yajo Nov 13, 2017

Choose a reason for hiding this comment

yajo Nov 13, 2017

Choose a reason for hiding this comment

yajo Nov 13, 2017

Choose a reason for hiding this comment

jnegrete commented Nov 13, 2017 via email

yajo Nov 14, 2017

Choose a reason for hiding this comment

CasVissers-360ERP commented Nov 15, 2017 • edited

jnegrete commented Nov 15, 2017 via email

yajo commented Nov 16, 2017

RoelAdriaans commented Nov 17, 2017

pedrobaeza commented Nov 17, 2017

yajo commented Nov 17, 2017

yajo left a comment •

edited

CasVissers-360ERP commented Nov 15, 2017 •

edited