Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade/11.0 base technical features #1012

Closed
wants to merge 17 commits into from
Closed

Upgrade/11.0 base technical features #1012

wants to merge 17 commits into from

Conversation

StefanRijnhart
Copy link
Member

No description provided.

StefanRijnhart and others added 14 commits October 5, 2017 16:28
@StefanRijnhart StefanRijnhart added this to the 11.0 milestone Oct 5, 2017
@pedrobaeza pedrobaeza mentioned this pull request Oct 5, 2017
Closed
92 tasks
bealdav
bealdav reviewed Oct 5, 2017
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo I suppose

base_technical_features/models/ir_ui_menu.py Outdated
# coding: utf-8
# © 2016 Opener B.V. (<https://opener.am>)
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
from openerp import api, models
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openerp ? opener ! ? :D

legalsylvain
legalsylvain approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the two last commits 10b5c9d and 251a34b seems to be quiet unrelated to the purpose of the PR (porting base_technical_feature module), but well, as it is the first module to be ported in V11, not a big deal.
Thanks a lot. 👍 (code review, no test.)

elicoidal
elicoidal approved these changes Oct 6, 2017
View reviewed changes
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some details. LGTM

base_technical_features/README.rst Outdated
<https://github.com/OCA/server-tools/issues>`_. In case of trouble, please
check there if your issue has already been reported. If you spotted it first,
help us smashing it by providing a detailed and welcomed `feedback
<https://github.com/OCA/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this last part

base_technical_features/README.rst Outdated

.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/149/10.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11

@StefanRijnhart StefanRijnhart force-pushed the upgrade/11.0-base_technical_features branch from 251a34b to 1aaa10d Compare October 6, 2017 10:40
@StefanRijnhart
Copy link
Member Author

Thanks for the reviews! @bealdav @elicoidal please review the fixes.

@pedrobaeza
Copy link
Member

Please move this PR to https://github.com/OCA/server-ux according #1006

@StefanRijnhart
Copy link
Member Author

OCA/server-ux#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bealdav bealdav bealdav approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

@atchuthan atchuthan atchuthan approved these changes

@moylop260 moylop260 moylop260 approved these changes

@elicoidal elicoidal elicoidal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@StefanRijnhart @pedrobaeza @bealdav @legalsylvain @atchuthan @moylop260 @elicoidal @oca-transbot @sbidoul @hbrunn