Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Split Server-Tools for v11 #1006

Closed
lasley opened this issue Oct 2, 2017 · 22 comments
Closed

[RFC] Split Server-Tools for v11 #1006

lasley opened this issue Oct 2, 2017 · 22 comments
Labels
Milestone

Comments

@lasley
Copy link
Contributor

lasley commented Oct 2, 2017

Bringing this in from a mailing list thread for final discussion.

From @dreispt (there's more in the thread, but this is the one that's still relevant right now and should be discussed):

Hello,

I believe that the repo can be subdivided in several more focused ones.

I propose to keep OCA/serverl-tools mostly for features related to configuration and administration tasks.
The other features can be moved to a few new spinf-off repos.

I can think of four new repos to create as spin-offs:

  • OCA/server-auth (10 modules): Authentication related
  • OCA/server-backend (5 modules): Server ORM extensions, new fields
  • OCA/server-brand (8 modules and counting): (De)branding related
  • OCA/server-ux (11 modules): Server side features for usability and user experience related

Supporting the above division, and as a starting point for the discussion, I prepared this spreadsheet:
https://docs.google.com/spreadsheets/d/1Xg95cW4TFMf_Lo5i_CZC_qOOfN8RgxPRc0LJTLTkdUI/edit?usp=sharing

cc @pedrobaeza @hbrunn @OCA/board

@lasley lasley added the question label Oct 2, 2017
@lasley lasley added this to the 11.0 milestone Oct 2, 2017
@dreispt
Copy link
Sponsor Member

dreispt commented Oct 9, 2017

Bringing up this again was on my list, thanks a lot for bringing it up Dave.
Experience tells us that focused repositories have better direction and more motivated maintainers.
This repository covers too much different topics for it to be effectively maintained.
It also has signs of being too large, looking at the number of existing modules and open PRs.

The list spinoffs proposed is quite old, so they might need an update.

@JordiBForgeFlow
Copy link
Sponsor Member

@dreispt I do not see consensus, and at the same time I see that the PR's to v11 are occurring as we speak. I propose to defer this topic until v12, as it seems that this kind of structural changes need to be planned well in advance of a new release.

@elicoidal
Copy link

Unfortunately I have to agree that this conversation is starting too late: we need to plan now the repository structure for v12 NOW.

@JordiBForgeFlow JordiBForgeFlow changed the title [RFC] Split Server-Tools for v11 [RFC] Split Server-Tools for v12 Oct 9, 2017
@JordiBForgeFlow JordiBForgeFlow modified the milestones: 11.0, 12.0 Oct 9, 2017
@JordiBForgeFlow
Copy link
Sponsor Member

OK, I have renamed the issue accordingly.

@pedrobaeza
Copy link
Member

No, it can be perfectly done in v11, and more as repo has been emptied. I'm creating the repos next day.

@lasley
Copy link
Contributor Author

lasley commented Oct 9, 2017

I brought this topic up back in June August. My standpoint is that we should do it now or it will never get done.

@JordiBForgeFlow JordiBForgeFlow changed the title [RFC] Split Server-Tools for v12 [RFC] Split Server-Tools for v11 Oct 9, 2017
@JordiBForgeFlow
Copy link
Sponsor Member

If @pedrobaeza creates the repos then it is ok. We have some PR's pending to merge to v11, and we'll wait until he is done to decide where to put them.

@dreispt
Copy link
Sponsor Member

dreispt commented Oct 10, 2017

@jbeficent It is not too late, the v11 branches are still empty.
AFAICR there was no opposition to this move, it just wasn't implemented.
Maybe @lasley has a link for the discussion.

@JordiBForgeFlow
Copy link
Sponsor Member

@dreispt no problem. We are so eager to start pushing to v11!!! I will wait for @pedrobaeza

@pedrobaeza
Copy link
Member

I'm on it!

@pedrobaeza
Copy link
Member

OK, I have created all the new repositories. You can start pushing to them. Closing this issue and including the document with the mapping on the migration issue.

@JordiBForgeFlow
Copy link
Sponsor Member

Thanks!!

@gurneyalex
Copy link
Member

thanks @lasley and @pedrobaeza

@hbrunn
Copy link
Member

hbrunn commented Oct 10, 2017

do we also want to ask people proposing new modules to server-tools in lower versions to move their PRs there? Would make sense imho
(edit: Of course only unmerged PRs that really introduce a new module)

@pedrobaeza
Copy link
Member

Well, I haven't created branches for lower versions, but if you think it's interesting, then go ahead.

@elicoidal
Copy link

Shall we advertise it in the contributor ML?

@pedrobaeza
Copy link
Member

Yeah, it can be interesting. And it should be part of next newsletter.

@hbrunn
Copy link
Member

hbrunn commented Oct 10, 2017

first time I review such a PR I'll create the branch - don't see a reason to do that beforehand now

@pedrobaeza
Copy link
Member

OK, agreed

@lasley
Copy link
Contributor Author

lasley commented Oct 10, 2017

And it should be part of next newsletter.

I created a ticket so we don't forget for the newsletter. Good idea

@dreispt
Copy link
Sponsor Member

dreispt commented Oct 10, 2017

To help people with what goes where, we should have v11 migration issues with the list of modules excepted to be migrated on each of the repos.

@dreispt
Copy link
Sponsor Member

dreispt commented Oct 10, 2017

Regrading the ML communication, it should done asap. In the next newsletter we will also mention that, with a link to the ML message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants